Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 1567953002: Precompilation: (Closed)

Created:
4 years, 11 months ago by rmacnak
Modified:
4 years, 11 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Precompilation: - When using --compile_all + --noopt, run Dart_CompileAll before Dart_Precompile to avoid skipping functions dropped by Precompile / asserting out on functions retained but uncompiled by Precompile. - Fail gracefully when attempting to use more than one of --noopt, --gen_precompiled_snapshot, or --run_precompiled_snapshot. - Fix tree shaking roots to include the right VM entry point for creating assertion failures. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/9328d724f8a5e2ea715c82914b0a3ad7dbcd55b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -7 lines) Patch
M runtime/bin/main.cc View 3 chunks +23 lines, -6 lines 0 comments Download
M runtime/vm/precompiler.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 11 months ago (2016-01-07 18:46:08 UTC) #2
Florian Schneider
lgtm
4 years, 11 months ago (2016-01-08 11:19:48 UTC) #3
rmacnak
4 years, 11 months ago (2016-01-08 18:19:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9328d724f8a5e2ea715c82914b0a3ad7dbcd55b1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698