Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1567903002: [Test - Do Not Commit] Stop blocking requests for new windows (Closed)

Created:
4 years, 11 months ago by Charlie Harrison
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Test - Do Not Commit] Stop blocking requests for new windows The code that blocks/resumes requests for new windows (window.open) originally was to prevent bugs with parenting windows under NPAPI. Since PPAPI does not have this problem, we should be able to remove this code. BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Patch Set 2 : App window contents - stop blocking! #

Patch Set 3 : cosmetic changes (trybots previous) #

Patch Set 4 : merge onto #371523 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -105 lines) Patch
M content/browser/frame_host/render_frame_host_impl.h View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_helper.h View 1 2 chunks +0 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_helper.cc View 1 3 chunks +0 lines, -20 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 2 chunks +0 lines, -9 lines 0 comments Download
M content/public/browser/render_process_host.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/test/mock_render_process_host.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/test/mock_render_process_host.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/browser/app_window/app_window_contents.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/browser/app_window/app_window_contents.cc View 1 2 4 chunks +1 line, -42 lines 0 comments Download

Messages

Total messages: 3 (3 generated)
Charlie Harrison
Description was changed from ========== [Test dont review] Stop blocking requests for new windows BUG= ...
4 years, 11 months ago (2016-01-07 22:49:19 UTC) #1
Charlie Harrison
Description was changed from ========== [Test dont review] Stop blocking requests for new windows The ...
4 years, 11 months ago (2016-01-07 22:49:39 UTC) #2
Charlie Harrison
4 years, 10 months ago (2016-01-26 20:16:49 UTC) #3 
Description was changed from

==========
[Test - Do Not Commit] Stop blocking requests for new windows

The code that blocks/resumes requests for new windows (window.open) originally
was to prevent bugs with parenting windows under NPAPI. Since PPAPI does not
have this problem, we should be able to remove this code.

BUG=
==========

to

==========
[Test - Do Not Commit] Stop blocking requests for new windows

The code that blocks/resumes requests for new windows (window.open) originally
was to prevent bugs with parenting windows under NPAPI. Since PPAPI does not
have this problem, we should be able to remove this code.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

Powered by Google App Engine
This is Rietveld 408576698