Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Issue 15679014: Add --enable-webkit-media-source for Android instead of hardcoding it to be disabled. (Closed)

Created:
7 years, 6 months ago by scherkus (not reviewing)
Modified:
7 years, 6 months ago
Reviewers:
jamesr, qinmin, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, wonsik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add --enable-webkit-media-source for Android instead of hardcoding it to be disabled. BUG=233420 R=jam@chromium.org, jamesr@chromium.org, qinmin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203268

Patch Set 1 : #

Patch Set 2 : add chrome bits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -9 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +16 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 chunks +10 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
scherkus (not reviewing)
qinmin: PTAL jamesr: OWNERS wonsik: FYI on GTV stuff
7 years, 6 months ago (2013-05-29 23:52:47 UTC) #1
qinmin
lgtm
7 years, 6 months ago (2013-05-30 01:17:49 UTC) #2
scherkus (not reviewing)
ping jamesr for OWNERS
7 years, 6 months ago (2013-05-30 21:11:47 UTC) #3
jamesr
lgtm for content/renderer/render_thread_impl, but that's the only file in this patch I have OWNERS on
7 years, 6 months ago (2013-05-30 21:18:50 UTC) #4
jamesr
(the rest lgtm as well, but I don't have authority to OWNERS it)
7 years, 6 months ago (2013-05-30 21:19:03 UTC) #5
scherkus (not reviewing)
On 2013/05/30 21:19:03, jamesr wrote: > (the rest lgtm as well, but I don't have ...
7 years, 6 months ago (2013-05-30 21:25:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/15679014/6001
7 years, 6 months ago (2013-05-30 21:25:40 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=5982
7 years, 6 months ago (2013-05-30 21:35:59 UTC) #8
scherkus (not reviewing)
nope I was wrong -- jam: OWNERS for content/*
7 years, 6 months ago (2013-05-30 21:38:19 UTC) #9
jam
lgtm
7 years, 6 months ago (2013-05-30 22:41:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/15679014/6001
7 years, 6 months ago (2013-05-30 22:52:19 UTC) #11
scherkus (not reviewing)
7 years, 6 months ago (2013-05-30 23:53:05 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 manually as r203268 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698