gm/etc1bitmap.cpp - Issue 1567893002: Fix crash when ETC1 codec is not supported.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/etc1bitmap.cpp

Issue 1567893002: Fix crash when ETC1 codec is not supported. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gm/etc1bitmap.cpp

diff --git a/gm/etc1bitmap.cpp b/gm/etc1bitmap.cpp

index d9b08d1e8642c34af15f84f2ab1546d9583ee950..6b3b3aff17f93947c7f6a3c46a0e577b7f7c3003 100644

--- a/gm/etc1bitmap.cpp

+++ b/gm/etc1bitmap.cpp

@@ -105,7 +105,9 @@ protected:

}

SkAutoTUnref<SkImage> image(SkImage::NewFromEncoded(fileData));

- canvas->drawImage(image, 0, 0);

+ if (image) {

djsollen 2016/01/07 14:59:19 should we print a debug statement if image == null

+ canvas->drawImage(image, 0, 0);

+ }

}

private:

« no previous file with comments | « no previous file | no next file » | no next file with comments »