Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1567893002: Fix crash when ETC1 codec is not supported. (Closed)

Created:
4 years, 11 months ago by djsollen
Modified:
4 years, 11 months ago
Reviewers:
reed1, tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : better comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M gm/etc1bitmap.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
djsollen
4 years, 11 months ago (2016-01-07 14:58:31 UTC) #3
djsollen
https://codereview.chromium.org/1567893002/diff/1/gm/etc1bitmap.cpp File gm/etc1bitmap.cpp (right): https://codereview.chromium.org/1567893002/diff/1/gm/etc1bitmap.cpp#newcode108 gm/etc1bitmap.cpp:108: if (image) { should we print a debug statement ...
4 years, 11 months ago (2016-01-07 14:59:19 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1567893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1567893002/20001
4 years, 11 months ago (2016-01-07 15:03:37 UTC) #6
tomhudson
On 2016/01/07 14:59:19, djsollen wrote: > should we print a debug statement if image == ...
4 years, 11 months ago (2016-01-07 15:17:34 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-07 15:21:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1567893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1567893002/20001
4 years, 11 months ago (2016-01-07 15:22:05 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 15:22:49 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/19aa2b08678499a0d9c146bcd409a8f73f5e5d5c

Powered by Google App Engine
This is Rietveld 408576698