Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 1567863004: Fix raise to use Exception instead of raw strings (Closed)

Created:
4 years, 11 months ago by brucedawson
Modified:
4 years, 11 months ago
Reviewers:
scottmg
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix raise to use Exception instead of raw strings I coded these incorrectly in a previous change and hit them when building a VS package. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298156

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M win_toolchain/package_from_installed.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
brucedawson
Minor bug fix. PTAL.
4 years, 11 months ago (2016-01-07 21:22:20 UTC) #2
scottmg
lgtm
4 years, 11 months ago (2016-01-07 21:32:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1567863004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1567863004/1
4 years, 11 months ago (2016-01-07 21:35:12 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 21:37:48 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298156

Powered by Google App Engine
This is Rietveld 408576698