test/cctest/wasm/test-run-wasm.cc - Issue 1567853002: [wasm] OOB test should pass on all architectures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/wasm/test-run-wasm.cc

Issue 1567853002: [wasm] OOB test should pass on all architectures. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/wasm/test-run-wasm.cc

diff --git a/test/cctest/wasm/test-run-wasm.cc b/test/cctest/wasm/test-run-wasm.cc

index fd41cd9d549dcd4fbd650483e948fa1c4d16895a..1a01170687d7937bbee46221a7c833d2dd2b5b60 100644

--- a/test/cctest/wasm/test-run-wasm.cc

+++ b/test/cctest/wasm/test-run-wasm.cc

@@ -1911,8 +1911,6 @@ TEST(Run_Wasm_StoreMemI32_offset) {

}

-#if WASM_64

-// TODO(titzer): Figure out why this fails on 32-bit architectures.

TEST(Run_Wasm_StoreMem_offset_oob) {

TestingModule module;

byte* memory = module.AddMemoryElems<byte>(32);

@@ -1949,7 +1947,6 @@ TEST(Run_Wasm_StoreMem_offset_oob) {

}

-#endif

#if WASM_64

« no previous file with comments | « no previous file | no next file » | no next file with comments »