Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1567733004: Add diagnostic message if external blob files cannot be loaded. (Closed)

Created:
4 years, 11 months ago by Yang
Modified:
4 years, 11 months ago
Reviewers:
vogelheim
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add diagnostic message if external blob files cannot be loaded. R=vogelheim@chromium.org Committed: https://crrev.com/e2cb4c225ed7d21244dbef51761009fdd1b91638 Cr-Commit-Position: refs/heads/master@{#33153}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M src/snapshot/natives-external.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/startup-data-util.cc View 3 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Yang
4 years, 11 months ago (2016-01-07 10:46:31 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1567733004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1567733004/1
4 years, 11 months ago (2016-01-07 10:47:18 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-07 11:21:09 UTC) #5
vogelheim
lgtm
4 years, 11 months ago (2016-01-07 11:55:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1567733004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1567733004/1
4 years, 11 months ago (2016-01-07 11:57:00 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-07 11:58:18 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 11:58:44 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e2cb4c225ed7d21244dbef51761009fdd1b91638
Cr-Commit-Position: refs/heads/master@{#33153}

Powered by Google App Engine
This is Rietveld 408576698