Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: gm/rebaseline_server/static/view.html

Issue 156773003: rebaseline_server: add "show only"/"show all" buttons to some columns (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gm/rebaseline_server/static/view.html
diff --git a/gm/rebaseline_server/static/view.html b/gm/rebaseline_server/static/view.html
index 46d6ab8be1ad9b3c3cceddc95a24fd5bed7bcf70..79335ca861082832f5a5b98534020ee522dc8b7e 100644
--- a/gm/rebaseline_server/static/view.html
+++ b/gm/rebaseline_server/static/view.html
@@ -276,22 +276,61 @@
</th>
</tr>
- <!-- For most columns... if the user clicks on the cell, and we are on
- the default tab, update the filter to only show results with the
- same value for this category.
- This is made a bit tricky by the fact that AngularJS expressions
- do not allow control flow statements. See
- http://docs.angularjs.org/guide/expression -->
<tr ng-repeat="result in limitedTestData" ng-controller="ImageController">
- <td ng-click="(viewingTab != defaultTab) || showOnlyResultType(result.resultType)">
+ <td>
{{result.resultType}}
+ <br>
+ <button class="show-only-button"
+ ng-hide="viewingTab != defaultTab"
+ ng-click="showOnlyResultType(result.resultType)"
+ title="show only results of type '{{result.resultType}}'">
+ show only
+ </button>
+ <br>
+ <button class="show-all-button"
+ ng-hide="viewingTab != defaultTab"
+ ng-disabled="0 == setSize(hiddenResultTypes)"
+ ng-click="showAllResultTypes()"
+ title="show results of all types">
+ show all
+ </button>
</td>
- <td ng-repeat="categoryName in ['builder', 'test']"
- ng-click="(viewingTab != defaultTab) || setCategoryValueMatch(categoryName, result[categoryName])">
+ <td ng-repeat="categoryName in ['builder', 'test']">
{{result[categoryName]}}
+ <br>
+ <button class="show-only-button"
+ ng-hide="viewingTab != defaultTab"
+ ng-disabled="result[categoryName] == categoryValueMatch[categoryName]"
+ ng-click="setCategoryValueMatch(categoryName, result[categoryName])"
+ title="show only results of {{categoryName}} '{{result[categoryName]}}'">
+ show only
+ </button>
+ <br>
+ <button class="show-all-button"
+ ng-hide="viewingTab != defaultTab"
+ ng-disabled="'' == categoryValueMatch[categoryName]"
+ ng-click="setCategoryValueMatch(categoryName, '')"
+ title="show results of all {{categoryName}}s">
+ show all
+ </button>
</td>
- <td ng-click="(viewingTab != defaultTab) || showOnlyConfig(result.config)">
+ <td>
{{result.config}}
+ <br>
+ <button class="show-only-button"
+ ng-hide="viewingTab != defaultTab"
+ ng-click="showOnlyConfig(result.config)"
+ title="show only results of config '{{result.config}}'">
+ show only
+ </button>
+ <br>
+ <button class="show-all-button"
+ ng-hide="viewingTab != defaultTab"
+ ng-disabled="0 == setSize(hiddenConfigs)"
+ ng-click="showAllConfigs()"
+ title="show results of all configs">
+ show all
+ </button>
</td>
<td>
<a ng-repeat="bug in result['bugs']"
« gm/rebaseline_server/static/loader.js ('K') | « gm/rebaseline_server/static/view.css ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698