third_party/WebKit/Source/web/WebPluginContainerImpl.cpp - Issue 1567623007: Traverse into subdocuments when mapping plugin rects from absolute to local space.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

Issue 1567623007: Traverse into subdocuments when mapping plugin rects from absolute to local space. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/WebPluginContainerImpl.h ('k') | third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp b/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

index 4b35fb59ee4b01c10cbd2398f3532bf82bd80c48..601bd6297745384d121e71948b1080650a0b7f66 100644

--- a/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

+++ b/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

@@ -945,8 +945,8 @@ void WebPluginContainerImpl::computeClipRectsForPlugin(

clippedLocalRect.intersect(rootView->frameView()->visibleContentRect());

// TODO(chrishtr): intentionally ignore transform, because the positioning of frameRect() does also. This is probably wrong.

wkorman 2016/01/07 18:52:25 Reading line 931 I also wondered why we wouldn't w

chrishtr 2016/01/07 19:06:02 frameRect() is in the space of the containing fram

- unclippedIntLocalRect = box->absoluteToLocalQuad(FloatRect(unclippedIntLocalRect)).enclosingBoundingBox();

- clippedLocalRect = box->absoluteToLocalQuad(FloatRect(clippedLocalRect)).enclosingBoundingBox();

+ unclippedIntLocalRect = box->absoluteToLocalQuad(FloatRect(unclippedIntLocalRect), TraverseDocumentBoundaries).enclosingBoundingBox();

+ clippedLocalRect = box->absoluteToLocalQuad(FloatRect(clippedLocalRect), TraverseDocumentBoundaries).enclosingBoundingBox();

}

void WebPluginContainerImpl::calculateGeometry(IntRect& windowRect, IntRect& clipRect, IntRect& unobscuredRect, Vector<IntRect>& cutOutRects)

@@ -965,4 +965,4 @@ void WebPluginContainerImpl::calculateGeometry(IntRect& windowRect, IntRect& cli

cutOutRects[i].move(-frameRect().x(), -frameRect().y());

}

-} // namespace blinkf

+} // namespace blink