Traverse into subdocuments when mapping plugin rects from absolute to local space.

Traverse into subdocuments when mapping plugin rects from absolute to local space.

BUG=560707, 564087
Committed: https://crrev.com/ef3591c447091eae0e5a12e4b7baac7bd5fe707a
Cr-Commit-Position: refs/heads/master@{#368145}

[chrishtr, 2016-01-07 17:24:35]

Description was changed from

==========
none


none


none


none

BUG=
==========

to

==========
Traverse into subdocuments when mapping plugin rects from absolute to local
space.

BUG=560707
==========

[chrishtr, 2016-01-07 17:32:15]

chrishtr@chromium.org changed reviewers:
+ tommycli@chromium.org, wkorman@chromium.org

[chrishtr, 2016-01-07 17:32:22]

Description was changed from

==========
Traverse into subdocuments when mapping plugin rects from absolute to local
space.

BUG=560707
==========

to

==========
Traverse into subdocuments when mapping plugin rects from absolute to local
space.

BUG=560707,564087
==========

[wkorman, 2016-01-07 18:52:25]

lgtm

https://codereview.chromium.org/1567623007/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/WebPluginContainerImpl.cpp (right):

https://codereview.chromium.org/1567623007/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebPluginContainerImpl.cpp:947: // TODO(chrishtr):
intentionally ignore transform, because the positioning of frameRect() does
also. This is probably wrong.
Reading line 931 I also wondered why we wouldn't want to use
TraverseDocumentBoundaries there.

[chrishtr, 2016-01-07 19:06:02]

https://codereview.chromium.org/1567623007/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/WebPluginContainerImpl.cpp (right):

https://codereview.chromium.org/1567623007/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebPluginContainerImpl.cpp:947: // TODO(chrishtr):
intentionally ignore transform, because the positioning of frameRect() does
also. This is probably wrong.
On 2016/01/07 at 18:52:25, wkorman wrote:
> Reading line 931 I also wondered why we wouldn't want to use
TraverseDocumentBoundaries there.

frameRect() is in the space of the containing frame, not absolute screen space.
Fixed the comment.

[chrishtr, 2016-01-07 19:06:50]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-01-07 19:06:50]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/1567623007/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-01-07 19:07:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1567623007/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1567623007/80001

[commit-bot: I haz the power, 2016-01-07 20:34:35]

Committed patchset #6 (id:80001)

[commit-bot: I haz the power, 2016-01-07 20:35:34]

Description was changed from

==========
Traverse into subdocuments when mapping plugin rects from absolute to local
space.

BUG=560707,564087
==========

to

==========
Traverse into subdocuments when mapping plugin rects from absolute to local
space.

BUG=560707,564087

Committed: https://crrev.com/ef3591c447091eae0e5a12e4b7baac7bd5fe707a
Cr-Commit-Position: refs/heads/master@{#368145}
==========

[commit-bot: I haz the power, 2016-01-07 20:35:35]

Patchset 6 (id:??) landed as
https://crrev.com/ef3591c447091eae0e5a12e4b7baac7bd5fe707a
Cr-Commit-Position: refs/heads/master@{#368145}