Tests for SummarySdkAnalysisContext.

Tests for SummarySdkAnalysisContext.

The tests use the Dart SDK summary file which we include with the tests.

Not uploading the patch for pkg/analyzer/test/src/summary/sdk_analysis_summary because the file is too large.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/5debf16e881463d8b1c50e033e398647197698f8

[scheglov, 2016-01-06 03:56:46]

Description was changed from

==========
Tests for SummarySdkAnalysisContext.

The tests use the Dart SDK summary file which we include with the tests.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Tests for SummarySdkAnalysisContext.

The tests use the Dart SDK summary file which we include with the tests.

Not uploading the patch for pkg/analyzer/test/src/summary/sdk_analysis_summary
because the file is too large.

R=brianwilkerson@google.com
BUG=
==========

[scheglov, 2016-01-06 03:56:46]

scheglov@google.com changed reviewers:
+ paulberry@google.com

[Brian Wilkerson, 2016-01-06 15:13:26]

LGTM

[Paul Berry, 2016-01-06 15:46:15]

We need a mechanism for ensuring that
pkg/analyzer/test/src/summary/sdk_analysis_summary is updated when the summary
format changes or the SDK is updated.  I'd recommend either (a) generating
sdk_analysis_summary as part of the build process (instead of checking it in to
source control), or (b) doing something like we do for the other code generated
files, where we have a test that verifies that code generation is up to date,
and if it isn't, prints out the command to execute to regenerate the summary.

Personally I'd lean toward (a).

https://codereview.chromium.org/1567583002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/summary_sdk_test.dart (right):

https://codereview.chromium.org/1567583002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summary_sdk_test.dart:171: //    print(sdkBundle);
Did you mean to delete these commented-out lines?

[scheglov, 2016-01-06 16:18:07]

I will remove the SDK summary from the repo altogether.
This is a temporary situation when we need it in the tests.
Once we have the summary in the SDK itself, we will read it from there.
I will keep it locally for now.

[scheglov, 2016-01-06 16:18:55]

Description was changed from

==========
Tests for SummarySdkAnalysisContext.

The tests use the Dart SDK summary file which we include with the tests.

Not uploading the patch for pkg/analyzer/test/src/summary/sdk_analysis_summary
because the file is too large.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Tests for SummarySdkAnalysisContext.

The tests use the Dart SDK summary file which we include with the tests.

Not uploading the patch for pkg/analyzer/test/src/summary/sdk_analysis_summary
because the file is too large.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/5debf16e881463d8b1c50e033e398647197698f8
==========

[scheglov, 2016-01-06 16:18:56]

Committed patchset #3 (id:20001) manually as
5debf16e881463d8b1c50e033e398647197698f8 (presubmit successful).