Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1567503002: [Signin] Clean up unused method in VariationsSession. (Closed)

Created:
4 years, 11 months ago by maxbogue
Modified:
4 years, 11 months ago
Reviewers:
nyquist
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@amh
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Signin] Clean up unused method in VariationsSession. Part 3/3 in a series. BUG=517697 Committed: https://crrev.com/78f43737b2f960d125bfdfe9f6df7bf1eb586967 Cr-Commit-Position: refs/heads/master@{#368728}

Patch Set 1 #

Patch Set 2 : Move conversion to async to this change. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/metrics/VariationsSession.java View 1 2 1 chunk +1 line, -6 lines 0 comments Download

Depends on Patchset:

Issue 1566523002 Patch 40001

Messages

Total messages: 8 (3 generated)
maxbogue
For once downstream lands.
4 years, 11 months ago (2016-01-05 23:36:10 UTC) #2
nyquist
lgtm
4 years, 11 months ago (2016-01-07 01:18:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1567503002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1567503002/40001
4 years, 11 months ago (2016-01-11 22:56:36 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-12 00:11:51 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 00:13:07 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/78f43737b2f960d125bfdfe9f6df7bf1eb586967
Cr-Commit-Position: refs/heads/master@{#368728}

Powered by Google App Engine
This is Rietveld 408576698