Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: trunk/src/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc

Issue 15675014: Revert 203015 "Add ManagedUserTokenFetcher to fetch scoped-down ..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/src/chrome/browser/managed_mode/managed_user_refresh_token_fetcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
===================================================================
--- trunk/src/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc (revision 203118)
+++ trunk/src/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc (working copy)
@@ -324,7 +324,10 @@
if (robot_auth_fetch_status_ == DM_STATUS_SUCCESS) {
net::TestURLFetcher* url_fetcher = url_fetcher_factory_.GetFetcherByID(0);
ASSERT_TRUE(url_fetcher);
- url_fetcher->SetMaxRetriesOn5xx(0);
+ // The logic in GaiaOAuthClient seems broken, it always retries 1x on
+ // non-200 response codes, even if the retries are set to 0. Seems like
+ // its num_retries_ > source->GetMaxRetriesOn5xx() should have a >=?
+ url_fetcher->SetMaxRetriesOn5xx(-2);
url_fetcher->set_status(net::URLRequestStatus());
url_fetcher->set_response_code(url_fetcher_response_code_);
url_fetcher->SetResponseString(url_fetcher_response_string_);
« no previous file with comments | « no previous file | trunk/src/chrome/browser/managed_mode/managed_user_refresh_token_fetcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698