chrome/test/data/extensions/api_test/messaging/connect_crash/test.js - Issue 1567423002: Ensure that sendMessage's callback is called.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/messaging/connect_crash/test.js

Issue 1567423002: Ensure that sendMessage's callback is called. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clarify intent Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/messaging/connect_crash/page.js ('k') | extensions/renderer/resources/messaging.js » ('j') | extensions/renderer/resources/messaging.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/messaging/connect_crash/test.js

diff --git a/chrome/test/data/extensions/api_test/messaging/connect_crash/test.js b/chrome/test/data/extensions/api_test/messaging/connect_crash/test.js

index dbb865d112636e579aa61faf1370a032a8c2122c..d9f6db2897d509701e0c4d566b559772de84d25e 100644

--- a/chrome/test/data/extensions/api_test/messaging/connect_crash/test.js

+++ b/chrome/test/data/extensions/api_test/messaging/connect_crash/test.js

@@ -21,7 +21,8 @@ chrome.runtime.onConnect.addListener(function(port) {

chrome.tabs.sendMessage(port.sender.tab.id, 'Rob says hi', function() {

chrome.test.log('tab.sendMessage\'s response callback was invoked');

- chrome.test.assertNoLastError();

+ chrome.test.assertLastError(

+ 'The message port closed before a reponse was received.');

succeed2();

});