Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1567413002: [regexp] simplify unicode flag check. (Closed)

Created:
4 years, 11 months ago by Yang
Modified:
4 years, 11 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@unicoderegexpatom
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] simplify unicode flag check. It's sufficient to check for --harmony-unicode-regexps when parsing the regexp flags from string. R=neis@chromium.org Committed: https://crrev.com/45850f40129ee2ddd0747a2266cae37764c43add Cr-Commit-Position: refs/heads/master@{#33178}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M src/regexp/regexp-parser.cc View 8 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
4 years, 11 months ago (2016-01-08 12:14:02 UTC) #1
neis
lgtm
4 years, 11 months ago (2016-01-08 12:47:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1567413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1567413002/1
4 years, 11 months ago (2016-01-08 12:49:10 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-08 13:26:31 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 13:27:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/45850f40129ee2ddd0747a2266cae37764c43add
Cr-Commit-Position: refs/heads/master@{#33178}

Powered by Google App Engine
This is Rietveld 408576698