Issue 1567403004: dart2js: Eliminate the JsIrBuilderVisitor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1567403004: dart2js: Eliminate the JsIrBuilderVisitor. (Closed)

Created:
4 years, 11 months ago by Kevin Millikin (Google)

Modified:
4 years, 11 months ago

Reviewers:
asgerf, sra1

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js: Eliminate the JsIrBuilderVisitor. Since there is only one subclass of IrBuilderVisitor, make IrBuilderVisitor non-abstract and move all the subclass methods to it. BUG= R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/5aedac787aea452cd7abf553a04e1a4a629f4ac4

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2909 lines, -2973 lines)			Patch
	M	pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart	View		9 chunks	+45 lines, -14 lines	0 comments	Download
	M	pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart	View		4 chunks	+2864 lines, -2959 lines	0 comments	Download

Total messages: 5 (2 generated)

Kevin Millikin (Google)

4 years, 11 months ago (2016-01-08 21:07:29 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5aedac787aea452cd7abf553a04e1a4a629f4ac4 (presubmit successful).