Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1567393003: [runtime] Make Runtime::GetCallerArguments local to scopes. (Closed)

Created:
4 years, 11 months ago by Michael Starzinger
Modified:
4 years, 11 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-runtime-rest
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Make Runtime::GetCallerArguments local to scopes. R=mvstanton@chromium.org Committed: https://crrev.com/43d45493c6d0631b6063dd8a5bc72489c7930a5e Cr-Commit-Position: refs/heads/master@{#33177}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -79 lines) Patch
M src/runtime/runtime.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/runtime/runtime-function.cc View 2 chunks +0 lines, -62 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 7 chunks +71 lines, -8 lines 0 comments Download

Depends on Patchset:

Issue 1569223002 Patch 1

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 11 months ago (2016-01-08 12:41:24 UTC) #1
mvstanton
lgtm
4 years, 11 months ago (2016-01-08 12:44:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1567393003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1567393003/1
4 years, 11 months ago (2016-01-08 12:51:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-08 13:08:54 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 13:09:46 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/43d45493c6d0631b6063dd8a5bc72489c7930a5e
Cr-Commit-Position: refs/heads/master@{#33177}

Powered by Google App Engine
This is Rietveld 408576698