src/full-codegen/x64/full-codegen-x64.cc - Issue 1567353002: [date] Migrate Date field accessors to native builtins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/x64/full-codegen-x64.cc

Issue 1567353002: [date] Migrate Date field accessors to native builtins. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Moar work. ports. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/x64/full-codegen-x64.cc

diff --git a/src/full-codegen/x64/full-codegen-x64.cc b/src/full-codegen/x64/full-codegen-x64.cc

index 5c7135615171b36f867fe9425584d43d1dd2ac84..fb1c30b7b026bacb0b6a0f277fdbb30d42b7e699 100644

--- a/src/full-codegen/x64/full-codegen-x64.cc

+++ b/src/full-codegen/x64/full-codegen-x64.cc

@@ -3321,9 +3321,7 @@ void FullCodeGenerator::EmitDateField(CallRuntime* expr) {

} else {

Label runtime, done;

if (index->value() < JSDate::kFirstUncachedField) {

- ExternalReference stamp = ExternalReference::date_cache_stamp(isolate());

- Operand stamp_operand = __ ExternalOperand(stamp);

- __ movp(scratch, stamp_operand);

+ __ Load(scratch, ExternalReference::date_cache_stamp(isolate()));

__ cmpp(scratch, FieldOperand(object, JSDate::kCacheStampOffset));

__ j(not_equal, &runtime, Label::kNear);

__ movp(result, FieldOperand(object, JSDate::kValueOffset +

« no previous file with comments | « src/builtins.cc ('k') | src/ia32/builtins-ia32.cc » ('j') | no next file with comments »