Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Unified Diff: runtime/vm/mirrors_api_impl.cc

Issue 156733002: Change Dart_QualifiedTypeName to use VM code directly and not use the dart api function (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/mirrors_api_impl.cc
===================================================================
--- runtime/vm/mirrors_api_impl.cc (revision 32362)
+++ runtime/vm/mirrors_api_impl.cc (working copy)
@@ -42,7 +42,12 @@
if (obj.IsType() || obj.IsClass()) {
const Class& cls = (obj.IsType()) ?
Class::Handle(Type::Cast(obj).type_class()) : Class::Cast(obj);
- return Dart_NewStringFromCString(cls.ToCString());
+ const char* str = cls.ToCString();
+ if (str == NULL) {
+ RETURN_NULL_ERROR(str);
+ }
+ CHECK_CALLBACK_STATE(isolate);
+ return Api::NewHandle(isolate, String::New(str));
} else {
RETURN_TYPE_ERROR(isolate, object, Class/Type);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698