Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1567203004: DevTools: fix toolbar <select> background in Dark theme (Closed)

Created:
4 years, 11 months ago by caseq
Modified:
4 years, 11 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix toolbar <select> background in Dark theme BUG=572706 TBR=pfeldman@chromium.org Committed: https://crrev.com/50f67380499ef03afa7ebd83bbcfc9868791f1f3 Cr-Commit-Position: refs/heads/master@{#368523}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/toolbar.css View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1567203004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1567203004/1
4 years, 11 months ago (2016-01-09 03:11:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-09 04:39:25 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/50f67380499ef03afa7ebd83bbcfc9868791f1f3 Cr-Commit-Position: refs/heads/master@{#368523}
4 years, 11 months ago (2016-01-09 04:40:28 UTC) #5
caseq
4 years, 11 months ago (2016-01-11 18:05:09 UTC) #6
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1575123002/ by caseq@chromium.org.

The reason for reverting is: This was a bad fix, breaks non-white toolbars (i.e.
filter bar)..

Powered by Google App Engine
This is Rietveld 408576698