Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1567193002: Add GpuSurfaceLookup::AcquireJavaSurface for AVDA on Android. (Closed)

Created:
4 years, 11 months ago by watk
Modified:
4 years, 11 months ago
Reviewers:
no sievers
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add GpuSurfaceLookup::AcquireJavaSurface for AVDA on Android. AndroidVideoDecodeAccelerator, which runs in the GPU process, needs a way to get a java Surface from the browser process. GpuSurfaceLookup and SurfaceTextureManagerImpl already provide a way to get an ANativeWindow but not the corresponding java Surface. This new method returns the java surface. BUG=533630 Committed: https://crrev.com/2b0e76f6c665b2f0988315591276f08906420cbd Cr-Commit-Position: refs/heads/master@{#368478}

Patch Set 1 #

Patch Set 2 : Rename fail #

Patch Set 3 : compiler warning; remove std::move #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M content/app/android/child_process_service.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M content/common/gpu/gpu_surface_lookup.h View 2 chunks +8 lines, -0 lines 0 comments Download
M content/common/gpu/gpu_surface_lookup.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
watk
Hey sievers, ptal.
4 years, 11 months ago (2016-01-07 22:29:08 UTC) #2
no sievers
lgtm
4 years, 11 months ago (2016-01-08 00:24:58 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1567193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1567193002/1
4 years, 11 months ago (2016-01-08 00:28:11 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/5683)
4 years, 11 months ago (2016-01-08 00:56:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1567193002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1567193002/60001
4 years, 11 months ago (2016-01-08 23:51:50 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 11 months ago (2016-01-09 00:41:19 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-09 00:42:20 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2b0e76f6c665b2f0988315591276f08906420cbd
Cr-Commit-Position: refs/heads/master@{#368478}

Powered by Google App Engine
This is Rietveld 408576698