Use ::std for is_empty, is_class, add_xxx_reference, remove decay.

Use ::std for is_empty, is_class, add_xxx_reference, remove decay.

SkTLogic.h contains implemenetations of is_empty, is_class, decay,
decay_t, add_lvalue_reference, add_rvalue_reference, and
add_rvalue_reference_t. The declaration of is_class is only used by
is_empty. The current implementation of is_empty will not work
correctly with 'final'. The current implementation of 
add_lvalue_reference does not support clarifications in c++17. No Skia
code is currently using decay, decay_t, add_rvalue_reference, and 
add_rvalue_reference_t. In addition, there are no known issues with 
any of these in ::std with any supported compiler.

The implementations of is_function and is_convertible are commented to
note why they are still present.

Committed: https://skia.googlesource.com/skia/+/0e101667d604e4902eb24e0c0939d4f5b12c96ec

[bungeman-skia, 2016-01-08 18:31:20]

Description was changed from

==========
Use ::std for is_empty, is_class, add_xxx_reference, remove decay.

SkTLogic.h contains implemenetations of is_empty, is_class, decay,
decay_t, add_lvalue_reference, add_rvalue_reference, and
add_rvalue_reference_t. The declaration of is_class is only used by
is_empty. The current implementation of is_empty will not work
correctly with 'final'. No Skia code is currently using decay, decay_t,
add_rvalue_reference, and add_rvalue_reference_t. In addition, there are
no known issues with any of these in ::std with any supported compiler.

The implementations of is_function and is_convertible are commented to
note why they are still present.
==========

to

==========
Use ::std for is_empty, is_class, add_xxx_reference, remove decay.

SkTLogic.h contains implemenetations of is_empty, is_class, decay,
decay_t, add_lvalue_reference, add_rvalue_reference, and
add_rvalue_reference_t. The declaration of is_class is only used by
is_empty. The current implementation of is_empty will not work
correctly with 'final'. No Skia code is currently using decay, decay_t,
add_rvalue_reference, and add_rvalue_reference_t. In addition, there are
no known issues with any of these in ::std with any supported compiler.

The implementations of is_function and is_convertible are commented to
note why they are still present.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bungeman-skia, 2016-01-08 18:31:43]

Description was changed from

==========
Use ::std for is_empty, is_class, add_xxx_reference, remove decay.

SkTLogic.h contains implemenetations of is_empty, is_class, decay,
decay_t, add_lvalue_reference, add_rvalue_reference, and
add_rvalue_reference_t. The declaration of is_class is only used by
is_empty. The current implementation of is_empty will not work
correctly with 'final'. No Skia code is currently using decay, decay_t,
add_rvalue_reference, and add_rvalue_reference_t. In addition, there are
no known issues with any of these in ::std with any supported compiler.

The implementations of is_function and is_convertible are commented to
note why they are still present.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Use ::std for is_empty, is_class, add_xxx_reference, remove decay.

SkTLogic.h contains implemenetations of is_empty, is_class, decay,
decay_t, add_lvalue_reference, add_rvalue_reference, and
add_rvalue_reference_t. The declaration of is_class is only used by
is_empty. The current implementation of is_empty will not work
correctly with 'final'. No Skia code is currently using decay, decay_t,
add_rvalue_reference, and add_rvalue_reference_t. In addition, there are
no known issues with any of these in ::std with any supported compiler.

The implementations of is_function and is_convertible are commented to
note why they are still present.
==========

[bungeman-skia, 2016-01-08 18:33:43]

Description was changed from

==========
Use ::std for is_empty, is_class, add_xxx_reference, remove decay.

SkTLogic.h contains implemenetations of is_empty, is_class, decay,
decay_t, add_lvalue_reference, add_rvalue_reference, and
add_rvalue_reference_t. The declaration of is_class is only used by
is_empty. The current implementation of is_empty will not work
correctly with 'final'. No Skia code is currently using decay, decay_t,
add_rvalue_reference, and add_rvalue_reference_t. In addition, there are
no known issues with any of these in ::std with any supported compiler.

The implementations of is_function and is_convertible are commented to
note why they are still present.
==========

to

==========
Use ::std for is_empty, is_class, add_xxx_reference, remove decay.

SkTLogic.h contains implemenetations of is_empty, is_class, decay,
decay_t, add_lvalue_reference, add_rvalue_reference, and
add_rvalue_reference_t. The declaration of is_class is only used by
is_empty. The current implementation of is_empty will not work
correctly with 'final'. The current implementation of 
add_lvalue_reference does not support clarifications in c++17. No Skia
code is currently using decay, decay_t, add_rvalue_reference, and 
add_rvalue_reference_t. In addition, there are no known issues with 
any of these in ::std with any supported compiler.

The implementations of is_function and is_convertible are commented to
note why they are still present.
==========

[bungeman-skia, 2016-01-08 18:34:46]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-08 18:34:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1567123006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1567123006/1

[bungeman-skia, 2016-01-08 18:41:25]

bungeman@google.com changed reviewers:
+ mtklein@google.com

[bungeman-skia, 2016-01-08 18:41:25]

I think this is pretty much the most we can remove for now until we get Android
clang SDK updated or move to VS2015.

[mtklein, 2016-01-08 18:51:25]

lgtm

[commit-bot: I haz the power, 2016-01-08 18:57:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-08 18:57:39]

Dry run: This issue passed the CQ dry run.

[bungeman-skia, 2016-01-08 19:04:21]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2016-01-08 19:04:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1567123006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1567123006/1

[commit-bot: I haz the power, 2016-01-08 19:05:11]

Description was changed from

==========
Use ::std for is_empty, is_class, add_xxx_reference, remove decay.

SkTLogic.h contains implemenetations of is_empty, is_class, decay,
decay_t, add_lvalue_reference, add_rvalue_reference, and
add_rvalue_reference_t. The declaration of is_class is only used by
is_empty. The current implementation of is_empty will not work
correctly with 'final'. The current implementation of 
add_lvalue_reference does not support clarifications in c++17. No Skia
code is currently using decay, decay_t, add_rvalue_reference, and 
add_rvalue_reference_t. In addition, there are no known issues with 
any of these in ::std with any supported compiler.

The implementations of is_function and is_convertible are commented to
note why they are still present.
==========

to

==========
Use ::std for is_empty, is_class, add_xxx_reference, remove decay.

SkTLogic.h contains implemenetations of is_empty, is_class, decay,
decay_t, add_lvalue_reference, add_rvalue_reference, and
add_rvalue_reference_t. The declaration of is_class is only used by
is_empty. The current implementation of is_empty will not work
correctly with 'final'. The current implementation of 
add_lvalue_reference does not support clarifications in c++17. No Skia
code is currently using decay, decay_t, add_rvalue_reference, and 
add_rvalue_reference_t. In addition, there are no known issues with 
any of these in ::std with any supported compiler.

The implementations of is_function and is_convertible are commented to
note why they are still present.

Committed:
https://skia.googlesource.com/skia/+/0e101667d604e4902eb24e0c0939d4f5b12c96ec
==========

[commit-bot: I haz the power, 2016-01-08 19:05:12]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0e101667d604e4902eb24e0c0939d4f5b12c96ec