Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5064)

Unified Diff: chrome/browser/ui/ash/cast_config_delegate_media_router.h

Issue 1567103005: Replace base::CallbackList with base::ObserverList in CastConfigDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Add DLL export to fix windows build Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/cast_config_delegate_media_router.h
diff --git a/chrome/browser/ui/ash/cast_config_delegate_media_router.h b/chrome/browser/ui/ash/cast_config_delegate_media_router.h
index f1beae8ee2da4dce9f528144e89f31807ba1c5c1..ea50b4304f039bb7271502b85dd5d12e9520fc75 100644
--- a/chrome/browser/ui/ash/cast_config_delegate_media_router.h
+++ b/chrome/browser/ui/ash/cast_config_delegate_media_router.h
@@ -7,6 +7,7 @@
#include "ash/cast_config_delegate.h"
#include "base/macros.h"
+#include "base/observer_list.h"
namespace media_router {
class MediaRouter;
@@ -28,8 +29,9 @@ class CastConfigDelegateMediaRouter : public ash::CastConfigDelegate {
private:
// CastConfigDelegate:
bool HasCastExtension() const override;
- DeviceUpdateSubscription RegisterDeviceUpdateObserver(
- const ReceiversAndActivitesCallback& callback) override;
+
achuithb 2016/01/13 09:21:25 remove whitespace? Also I'd prefer Add/Remove Obse
jdufault 2016/01/13 19:43:26 Done.
+ void AddObserver(ash::CastConfigDelegate::Observer* observer) override;
+ void RemoveObserver(ash::CastConfigDelegate::Observer* observer) override;
void RequestDeviceRefresh() override;
void CastToReceiver(const std::string& receiver_id) override;
void StopCasting(const std::string& route_id) override;
@@ -41,7 +43,7 @@ class CastConfigDelegateMediaRouter : public ash::CastConfigDelegate {
CastDeviceCache* devices();
scoped_ptr<CastDeviceCache> devices_;
- base::CallbackList<void(const ReceiversAndActivities&)> callback_list_;
+ base::ObserverList<ash::CastConfigDelegate::Observer> observer_list_;
DISALLOW_COPY_AND_ASSIGN(CastConfigDelegateMediaRouter);
};

Powered by Google App Engine
This is Rietveld 408576698