chrome/browser/ui/ash/cast_config_delegate_chromeos.h - Issue 1567103005: Replace base::CallbackList with base::ObserverList in CastConfigDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/cast_config_delegate_chromeos.h

Issue 1567103005: Replace base::CallbackList with base::ObserverList in CastConfigDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Add TODO for proper fix Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/cast_devices_private/cast_devices_private_api.cc ('k') | chrome/browser/ui/ash/cast_config_delegate_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/cast_config_delegate_chromeos.h

diff --git a/chrome/browser/ui/ash/cast_config_delegate_chromeos.h b/chrome/browser/ui/ash/cast_config_delegate_chromeos.h

index 41b37704e01f22097aba421013643a5259eecc89..5c0826d443a6afb09d41764607a0701bf93ca2f1 100644

--- a/chrome/browser/ui/ash/cast_config_delegate_chromeos.h

+++ b/chrome/browser/ui/ash/cast_config_delegate_chromeos.h

@@ -23,13 +23,13 @@ class CastConfigDelegateChromeos : public ash::CastConfigDelegate {

private:

// CastConfigDelegate:

bool HasCastExtension() const override;

- DeviceUpdateSubscription RegisterDeviceUpdateObserver(

- const ReceiversAndActivitesCallback& callback) override;

void RequestDeviceRefresh() override;

void CastToReceiver(const std::string& receiver_id) override;

void StopCasting(const std::string& activity_id) override;

bool HasOptions() const override;

void LaunchCastOptions() override;

+ void AddObserver(ash::CastConfigDelegate::Observer* observer) override;

+ void RemoveObserver(ash::CastConfigDelegate::Observer* observer) override;

DISALLOW_COPY_AND_ASSIGN(CastConfigDelegateChromeos);

};