Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1567103003: Update V8BindingDesign.md per jochen's comment (Closed)

Created:
4 years, 11 months ago by haraken
Modified:
4 years, 11 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update V8BindingDesign.md per jochen's comment Apply jochen's comment in https://codereview.chromium.org/1542623004/. BUG= Committed: https://crrev.com/55ce6fb2cf3de90d9b326c31737b7c22301a6184 Cr-Commit-Position: refs/heads/master@{#368572}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md View 1 4 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
haraken
PTAL
4 years, 11 months ago (2016-01-08 05:19:00 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1567103003/diff/1/third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md File third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md (right): https://codereview.chromium.org/1567103003/diff/1/third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md#newcode11 third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md:11: An isolate is a concept of a heap in ...
4 years, 11 months ago (2016-01-08 14:09:20 UTC) #3
haraken
https://codereview.chromium.org/1567103003/diff/1/third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md File third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md (right): https://codereview.chromium.org/1567103003/diff/1/third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md#newcode11 third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md:11: An isolate is a concept of a heap in ...
4 years, 11 months ago (2016-01-08 14:26:49 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 11 months ago (2016-01-11 12:11:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1567103003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1567103003/20001
4 years, 11 months ago (2016-01-11 12:37:21 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-11 13:38:14 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 13:39:25 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/55ce6fb2cf3de90d9b326c31737b7c22301a6184
Cr-Commit-Position: refs/heads/master@{#368572}

Powered by Google App Engine
This is Rietveld 408576698