Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1567093002: Guard SkGpuDevice (Closed)

Created:
4 years, 11 months ago by joshua.litt
Modified:
4 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@gpudeviceguards2
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
M include/gpu/GrContext.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 40 chunks +45 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
joshualitt
Adding guards to SkGpuDevice(this is the last CL)
4 years, 11 months ago (2016-01-07 19:06:40 UTC) #3
robertphillips
lgtm
4 years, 11 months ago (2016-01-07 19:16:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1567093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1567093002/1
4 years, 11 months ago (2016-01-11 19:06:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.9-Clang-Arm7-Debug-iOS-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.9-Clang-Arm7-Debug-iOS-Trybot/builds/638) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, ...
4 years, 11 months ago (2016-01-11 19:07:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1567093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1567093002/20001
4 years, 11 months ago (2016-01-11 21:14:41 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/5246)
4 years, 11 months ago (2016-01-11 21:15:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1567093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1567093002/20001
4 years, 11 months ago (2016-01-11 21:19:52 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 21:29:33 UTC) #18
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/ce894007eb51c4dc34b2b6eb19ff6c772a1fb590

Powered by Google App Engine
This is Rietveld 408576698