Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: tests/RecordOptsTest.cpp

Issue 1567063002: Revert[2] of "add backdrop option to SaveLayerRec" (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: don't optimize-away the layer if there is a backdrop Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/core/SkRecordOpts.cpp ('K') | « src/core/SkRecorder.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/RecordOptsTest.cpp
diff --git a/tests/RecordOptsTest.cpp b/tests/RecordOptsTest.cpp
index dd6c410ed4d52723de40419ffa50caa0ba157442..a7c3ccd73297b7bae1a1b1de74848f6dbbe04367 100644
--- a/tests/RecordOptsTest.cpp
+++ b/tests/RecordOptsTest.cpp
@@ -114,6 +114,7 @@ static void assert_savelayer_restore(skiatest::Reporter* r,
}
}
+#include "SkBlurImageFilter.h"
DEF_TEST(RecordOpts_NoopSaveLayerDrawRestore, r) {
SkRecord record;
SkRecorder recorder(&record, W, H);
@@ -171,6 +172,13 @@ DEF_TEST(RecordOpts_NoopSaveLayerDrawRestore, r) {
const SkRecords::DrawRect* drawRect = assert_type<SkRecords::DrawRect>(r, record, 16);
REPORTER_ASSERT(r, drawRect != nullptr);
REPORTER_ASSERT(r, drawRect->paint.getColor() == 0x03020202);
+
+ // saveLayer w/ backdrop should NOT go away
+ SkAutoTUnref<SkImageFilter> filter(SkBlurImageFilter::Create(3, 3));
+ recorder.saveLayer({ nullptr, nullptr, filter, 0});
+ recorder.drawRect(draw, opaqueDrawPaint);
+ recorder.restore();
+ assert_savelayer_restore(r, &record, 18, false);
}
static void assert_merge_svg_opacity_and_filter_layers(skiatest::Reporter* r,
« src/core/SkRecordOpts.cpp ('K') | « src/core/SkRecorder.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698