Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1567063002: Revert[2] of "add backdrop option to SaveLayerRec" (Closed)

Created:
4 years, 11 months ago by reed1
Modified:
4 years, 11 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert[2] of "add backdrop option to SaveLayerRec" Reverted because of picture/serialization failure BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1567063002 TBR=mtklein Committed: https://skia.googlesource.com/skia/+/bfd5f171e6a3eccd7c4bede652a85fd76bcbce2a

Patch Set 1 #

Patch Set 2 : don't optimize-away the layer if there is a backdrop #

Total comments: 2

Patch Set 3 : add test and fix for svg-savelayer optimization #

Unified diffs Side-by-side diffs Delta from patch set Stats (+316 lines, -48 lines) Patch
M gm/imagefilters.cpp View 1 chunk +74 lines, -0 lines 0 comments Download
M include/core/SkCanvas.h View 1 chunk +15 lines, -4 lines 0 comments Download
M include/private/SkRecords.h View 2 chunks +2 lines, -0 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M samplecode/SampleLayers.cpp View 1 chunk +74 lines, -2 lines 0 comments Download
M src/core/SkCanvas.cpp View 5 chunks +10 lines, -8 lines 0 comments Download
M src/core/SkPictureFlat.h View 2 chunks +10 lines, -2 lines 0 comments Download
M src/core/SkPicturePlayback.cpp View 1 chunk +19 lines, -1 line 0 comments Download
M src/core/SkPictureRecord.cpp View 2 chunks +36 lines, -10 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRecordOpts.cpp View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M src/core/SkRecorder.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M tests/RecordOptsTest.cpp View 1 2 5 chunks +54 lines, -19 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1567063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1567063002/1
4 years, 11 months ago (2016-01-07 17:24:25 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/5080)
4 years, 11 months ago (2016-01-07 17:31:45 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1567063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1567063002/20001
4 years, 11 months ago (2016-01-07 18:21:04 UTC) #8
reed1
4 years, 11 months ago (2016-01-07 18:24:47 UTC) #10
mtklein
https://codereview.chromium.org/1567063002/diff/20001/src/core/SkRecordOpts.cpp File src/core/SkRecordOpts.cpp (right): https://codereview.chromium.org/1567063002/diff/20001/src/core/SkRecordOpts.cpp#newcode255 src/core/SkRecordOpts.cpp:255: static bool KillSaveLayerAndRestore(SkRecord* record, int saveLayerIndex) { This one ...
4 years, 11 months ago (2016-01-07 18:27:42 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-07 18:41:34 UTC) #13
reed1
ptal https://codereview.chromium.org/1567063002/diff/20001/src/core/SkRecordOpts.cpp File src/core/SkRecordOpts.cpp (right): https://codereview.chromium.org/1567063002/diff/20001/src/core/SkRecordOpts.cpp#newcode255 src/core/SkRecordOpts.cpp:255: static bool KillSaveLayerAndRestore(SkRecord* record, int saveLayerIndex) { On ...
4 years, 11 months ago (2016-01-07 19:09:18 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1567063002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1567063002/40001
4 years, 11 months ago (2016-01-07 19:09:26 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1567063002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1567063002/40001
4 years, 11 months ago (2016-01-07 19:27:20 UTC) #20
mtklein
lgtm
4 years, 11 months ago (2016-01-07 19:27:27 UTC) #21
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 19:28:13 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/bfd5f171e6a3eccd7c4bede652a85fd76bcbce2a

Powered by Google App Engine
This is Rietveld 408576698