Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 156703006: Cleanup: Remove unneeded browser_thread.h includes. (Closed)

Created:
6 years, 10 months ago by Lei Zhang
Modified:
6 years, 10 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, asanka, vandebo (ex-Chrome), felt, nkostylev+watch_chromium.org, tzik, browser-components-watch_chromium.org, rginda+watch_chromium.org, stuartmorgan+watch_chromium.org, sadrul, markusheintz_, aandrey+blink_chromium.org, stevenjb+watch_chromium.org, kinuko+watch, tim+watch_chromium.org, extensions-reviews_chromium.org, vsevik, jar (doing other things), benjhayden+dwatch_chromium.org, Ilya Sherman, jam, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, derat+watch_chromium.org, haitaol+watch_chromium.org, nhiroki, paulirish+reviews_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, kalyank, maniscalco+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, rsimha+watch_chromium.org, Lei Zhang, tfarina, ben+ash_chromium.org, yurys, asvitkine+watch_chromium.org, tommycli, davemoore+watch_chromium.org, Greg Billock, James Su, pfeldman
Visibility:
Public.

Description

Cleanup: Remove unneeded browser_thread.h includes. Do some lint cleanups too. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251011

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -90 lines) Patch
M chrome/browser/apps/ephemeral_app_launcher.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/autocomplete/history_quick_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/captive_portal/captive_portal_tab_reloader_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/external_cache.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_manager/fileapi_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/mounted_disk_monitor.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/kiosk_mode/kiosk_mode_idle_logout_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/wallpaper_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/mobile/mobile_activator.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_network_configuration_updater.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_policy_disk_cache.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/power/peripheral_battery_observer_browsertest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/component_updater/component_unpacker.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/permission_queue_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/devtools/browser_list_tabcontents_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/download/download_target_determiner_unittest.cc View 4 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/extensions/activity_log/activity_actions.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_process_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_process_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_service_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/system_display/display_info_provider_chromeos.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/system_info/system_info_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/system_info/system_info_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/system_info/system_info_provider.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/blob_reader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_sync_service.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/page_action_controller_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/webstore_inline_installer_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/feedback/feedback_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/url_index_private_data.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/lifetime/application_lifetime_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/managed_mode/managed_user_sync_service_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/iapps_data_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/iphoto_data_provider.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/itunes_data_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media_galleries/win/mtp_device_object_enumerator.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/win/mtp_device_operations_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/metrics/perf_provider_chromeos.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/notifications/desktop_notification_service_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_generation_manager.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/plugins/plugin_infobar_delegates.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_fetcher_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/signin/account_reconcilor.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/signin/profile_oauth2_token_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/storage_monitor/image_capture_device_manager.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/sync_prefs.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend_v1/remote_sync_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_service_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 4 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/ash/screenshot_taker_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/window_positioner_unittest.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/ash/tab_scrubber_browsertest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_common_unittest.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/zoom/zoom_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/usb/usb_context.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/usb/usb_context.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/usb/usb_device_handle.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/safe_browsing/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/base/chrome_test_launcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/test/base/view_event_test_base.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Lei Zhang
6 years, 10 months ago (2014-02-12 07:07:07 UTC) #1
James Hawkins
lgtm
6 years, 10 months ago (2014-02-13 00:36:05 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 10 months ago (2014-02-13 01:28:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/156703006/760001
6 years, 10 months ago (2014-02-13 01:31:53 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 02:21:59 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, ...
6 years, 10 months ago (2014-02-13 02:22:00 UTC) #6
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 10 months ago (2014-02-13 02:54:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/156703006/760001
6 years, 10 months ago (2014-02-13 02:55:06 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 15:08:38 UTC) #9
Message was sent while issue was closed. 
Change committed as 251011

Powered by Google App Engine
This is Rietveld 408576698