runtime/vm/constant_propagator.cc - Issue 1567023002: Fix assertion in ConstantPropagator::VisitInstanceOf.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/constant_propagator.cc

Issue 1567023002: Fix assertion in ConstantPropagator::VisitInstanceOf. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/constant_propagator.cc

diff --git a/runtime/vm/constant_propagator.cc b/runtime/vm/constant_propagator.cc

index 8792cf549164199d15cb31ac188e5acea040f9c2..695c23cbe8f349836d348ae296659e31e080bc80 100644

--- a/runtime/vm/constant_propagator.cc

+++ b/runtime/vm/constant_propagator.cc

@@ -743,7 +743,7 @@ void ConstantPropagator::VisitInstanceOf(InstanceOfInstr* instr) {

const Object& value = def->constant_value();

if (IsNonConstant(value)) {

const AbstractType& checked_type = instr->type();

- intptr_t value_cid = instr->value()->Type()->ToCid();

+ intptr_t value_cid = instr->value()->definition()->Type()->ToCid();

Representation rep = def->representation();

if ((checked_type.IsFloat32x4Type() && (rep == kUnboxedFloat32x4)) ||

(checked_type.IsInt32x4Type() && (rep == kUnboxedInt32x4)) ||

« no previous file with comments | « no previous file | no next file » | no next file with comments »