Issue 1567023002: Fix assertion in ConstantPropagator::VisitInstanceOf.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1567023002: Fix assertion in ConstantPropagator::VisitInstanceOf. (Closed)

Created:
4 years, 11 months ago by Vyacheslav Egorov (Google)

Modified:
4 years, 11 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix assertion in ConstantPropagator::VisitInstanceOf. Propagated type doesn't have to match value representation because it is affected by dominating checks (these checks will always deopt if there is a mismatch making all subsequent code dead). R=fschneider@google.com BUG=http://dartbug.com/25362 Committed: https://github.com/dart-lang/sdk/commit/122722f50b413f410fc05ed6822b8cb4ed42123b

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	runtime/vm/constant_propagator.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Vyacheslav Egorov (Google)

4 years, 11 months ago (2016-01-07 15:19:41 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
122722f50b413f410fc05ed6822b8cb4ed42123b (presubmit successful).