Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1566983004: Componentize the favicon for chrome://history (Closed)

Created:
4 years, 11 months ago by droger
Modified:
4 years, 11 months ago
Reviewers:
Nico, sdefresne
CC:
chromium-reviews, oshima+watch_chromium.org, Jamie Madill
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Componentize the favicon for chrome://history TBR=thakis Committed: https://crrev.com/1f69728f5099df74ada2bf45ae72a2d294aa3cdf Cr-Commit-Position: refs/heads/master@{#368569} Committed: https://crrev.com/7767e09b692252393c76a18e3a39cb0ac8b04d21 Cr-Commit-Position: refs/heads/master@{#370696}

Patch Set 1 : #

Patch Set 2 : rebase #

Messages

Total messages: 32 (19 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1566983004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1566983004/60001
4 years, 11 months ago (2016-01-08 12:56:26 UTC) #6
droger
4 years, 11 months ago (2016-01-08 12:57:11 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/156052) mac_chromium_compile_dbg_ng on ...
4 years, 11 months ago (2016-01-08 12:58:27 UTC) #10
sdefresne
lgtm
4 years, 11 months ago (2016-01-08 14:21:36 UTC) #11
droger
TBR=thakis for #include changes in chrome and tweak to tools/gritsettings/resource_ids
4 years, 11 months ago (2016-01-11 10:59:53 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1566983004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1566983004/120001
4 years, 11 months ago (2016-01-11 11:00:16 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:120001)
4 years, 11 months ago (2016-01-11 12:19:00 UTC) #20
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/1f69728f5099df74ada2bf45ae72a2d294aa3cdf Cr-Commit-Position: refs/heads/master@{#368569}
4 years, 11 months ago (2016-01-11 12:19:49 UTC) #22
Jamie Madill
A revert of this CL (patchset #2 id:120001) has been created in https://codereview.chromium.org/1571373002/ by jmadill@chromium.org. ...
4 years, 11 months ago (2016-01-11 15:56:13 UTC) #23
droger
Landed a speculative fix: https://codereview.chromium.org/1615823002/. Relanding now, with no changes, since the bug was presumably ...
4 years, 11 months ago (2016-01-21 14:12:27 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1566983004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1566983004/120001
4 years, 11 months ago (2016-01-21 14:15:06 UTC) #28
commit-bot: I haz the power
Committed patchset #2 (id:120001)
4 years, 11 months ago (2016-01-21 15:23:41 UTC) #30
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 15:24:57 UTC) #32
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7767e09b692252393c76a18e3a39cb0ac8b04d21
Cr-Commit-Position: refs/heads/master@{#370696}

Powered by Google App Engine
This is Rietveld 408576698