Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(291)

Issue 1566963004: Use cleanup with retry on Windows for all scripts. (Closed)

Created:
3 years, 7 months ago by kjellander_chromium
Modified:
3 years, 7 months ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/webrtc/webrtc.DEPS@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use cleanup with retry on Windows for all scripts. Make use of the helper function added in https://codereview.chromium.org/1514533002/ in more places, in particular in the copy_apprtc.py script. BUG=567538 TESTED=Ran a local gclient sync on Mac without any failures. TBR=phoglund@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/webrtc/webrtc.DEPS/+/ebc9b9802418dd1f11d6358e7fee7d3e110f592b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -49 lines) Patch
M build_apprtc_appengine_app.py View 2 chunks +2 lines, -2 lines 0 comments Download
M build_apprtc_collider.py View 1 chunk +1 line, -39 lines 0 comments Download
M copy_apprtc.py View 1 chunk +1 line, -6 lines 0 comments Download
M utils.py View 2 chunks +39 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
kjellander_chromium
TBRing to see if this can green up the build.
3 years, 7 months ago (2016-01-07 12:44:11 UTC) #3
kjellander_chromium
3 years, 7 months ago (2016-01-07 12:44:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ebc9b9802418dd1f11d6358e7fee7d3e110f592b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698