fpdfsdk/include/fpdfxfa/fpdfxfa_doc.h - Issue 1566903002: XFA: Change the destruction order inside CPDFXFA_Document to avoid UAFs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/include/fpdfxfa/fpdfxfa_doc.h

Issue 1566903002: XFA: Change the destruction order inside CPDFXFA_Document to avoid UAFs. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: nits Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/include/fpdfxfa/fpdfxfa_doc.h

diff --git a/fpdfsdk/include/fpdfxfa/fpdfxfa_doc.h b/fpdfsdk/include/fpdfxfa/fpdfxfa_doc.h

index 451b561ba0858c7aac3969337eed97822213ce7f..c61214371dff6ac0d71569dd9aa154568dc57f26 100644

--- a/fpdfsdk/include/fpdfxfa/fpdfxfa_doc.h

+++ b/fpdfsdk/include/fpdfxfa/fpdfxfa_doc.h

@@ -37,7 +37,6 @@ class CPDFXFA_Document : public IXFA_DocProvider {

int GetDocType() { return m_iDocType; }

CPDFSDK_Document* GetSDKDocument(CPDFDoc_Environment* pFormFillEnv);

- void ReleaseSDKDoc();

void FXRect2PDFRect(const CFX_RectF& fxRectF, CPDF_Rect& pdfRect);

« no previous file with comments | « no previous file | fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp » ('j') | no next file with comments »