Issue 1566893002: Avoid comparing size_t to be < 0 on AArch64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1566893002: Avoid comparing size_t to be < 0 on AArch64. (Closed)

Created:
4 years, 11 months ago by Lei Zhang

Modified:
4 years, 11 months ago

Reviewers:
Dmitry Skiba

CC:
google-breakpad-dev_googlegroups.com

Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Avoid comparing size_t to be < 0 on AArch64. cpu_features_entries is empty on AArch64 and causes tautological-compare warning when compiling with Clang. A=dskiba@google.com Original Review: https://codereview.chromium.org/1562223002/ BUG=chromium:539781 Committed: https://chromium.googlesource.com/breakpad/breakpad/+/400a1d9aa5c7627cadf044b88ae1c296449958b4

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/client/linux/minidump_writer/minidump_writer.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (2 generated)

Lei Zhang

4 years, 11 months ago (2016-01-07 00:16:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
400a1d9aa5c7627cadf044b88ae1c296449958b4 (presubmit successful).