Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: src/core/SkWriter32.cpp

Issue 156683004: Cleaner external buffer handling in SkWriter32 (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Make the SkWriter32 constructor call reset Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/core/SkWriter32.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkWriter32.cpp
diff --git a/src/core/SkWriter32.cpp b/src/core/SkWriter32.cpp
index 5e89ed655b70e5d83da4df2588704689898b52e6..7285459c3d1e5767fff762d0bb38a4a6f848a2a0 100644
--- a/src/core/SkWriter32.cpp
+++ b/src/core/SkWriter32.cpp
@@ -66,3 +66,21 @@ size_t SkWriter32::WriteStringSize(const char* str, size_t len) {
// add 1 since we also write a terminating 0
return SkAlign4(lenBytes + len + 1);
}
+
+void SkWriter32::growToAtLeast(size_t size) {
+ bool wasExternal = (fExternal != NULL) && (fData == fExternal);
+ // cause the buffer to grow
+ fInternal.setCount(size);
+ fData = fInternal.begin();
+ if (wasExternal) {
+ // we were external, so copy in the data
+ memcpy(fData, fExternal, fUsed);
+ }
+ // Find out the size the buffer grew to, it may be more than we asked for.
+ fCapacity = fInternal.reserved();
+ // Expand the array so all reserved space is "used", we maintain the
+ // amount we have written manually outside the array
+ fInternal.setCount(fCapacity);
+ SkASSERT(fInternal.count() == fCapacity);
+ SkASSERT(fInternal.reserved() == fCapacity);
+}
« no previous file with comments | « include/core/SkWriter32.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698