Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1566763002: Don’t suppress_wildcard crashpad.gyp:All on platforms where it works (Closed)

Created:
4 years, 11 months ago by Mark Mentovai
Modified:
4 years, 11 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org, tapted
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Don’t suppress_wildcard crashpad.gyp:All on platforms where it works This matches Chromium 01e379fac955. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/54048cfd78af0a54cf4a2d2ecfb83881f5c54590

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M crashpad.gyp View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Mark Mentovai
4 years, 11 months ago (2016-01-06 17:30:32 UTC) #2
Robert Sesek
lgtm
4 years, 11 months ago (2016-01-06 17:32:11 UTC) #3
Mark Mentovai
4 years, 11 months ago (2016-01-06 17:37:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
54048cfd78af0a54cf4a2d2ecfb83881f5c54590 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698