Issue 156673002: Revert "Unify paren handling in Parser and PreParser."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 156673002: Revert "Unify paren handling in Parser and PreParser." (Closed)

Created:
6 years, 10 months ago by marja

Modified:
6 years, 10 months ago

Reviewers:

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert "Unify paren handling in Parser and PreParser." This reverts r19140. Reason: Octane regression. BUG= TBR=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19147

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -76 lines)			Patch
M	src/ast.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/ast.cc	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	src/parser.cc	View	5 chunks	+14 lines, -9 lines	0 comments	Download
M	src/preparser.h	View	5 chunks	+42 lines, -5 lines	0 comments	Download
M	src/preparser.cc	View	3 chunks	+9 lines, -15 lines	0 comments	Download
M	test/cctest/test-parsing.cc	View	1 chunk	+0 lines, -33 lines	0 comments	Download

Total messages: 1 (0 generated)

marja

6 years, 10 months ago (2014-02-06 11:59:24 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r19147 (presubmit successful).