Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: content/browser/appcache/appcache_request_handler.h

Issue 1566713004: Fix a null AppCacheBackendImpl ptr crash in CompleteCrossSiteTransfer and re… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: bad_message Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/appcache/appcache_request_handler.h
diff --git a/content/browser/appcache/appcache_request_handler.h b/content/browser/appcache/appcache_request_handler.h
index d7b55e5a96b7feef7906d077785705d3b13e075d..97196ce992e89f9cc4b4a9fdf47c3900e1606ea3 100644
--- a/content/browser/appcache/appcache_request_handler.h
+++ b/content/browser/appcache/appcache_request_handler.h
@@ -25,6 +25,7 @@ class URLRequestJob;
namespace content {
class AppCacheRequestHandlerTest;
+class AppCacheService;
class AppCacheURLRequestJob;
// An instance is created for each net::URLRequest. The instance survives all
@@ -57,6 +58,9 @@ class CONTENT_EXPORT AppCacheRequestHandler
void PrepareForCrossSiteTransfer(int old_process_id);
void CompleteCrossSiteTransfer(int new_process_id, int new_host_id);
void MaybeCompleteCrossSiteTransferInOldProcess(int old_process_id);
+ bool SanityCheckIsSameService(AppCacheService* service) {
jsbell 2016/01/14 22:52:29 Add brief documentation here, i.e. why anyone woul
+ return !host_ || (host_->service() == service);
+ }
static bool IsMainResourceType(ResourceType type) {
return IsResourceTypeFrame(type) ||
« no previous file with comments | « content/browser/appcache/appcache_interceptor.cc ('k') | content/browser/appcache/appcache_request_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698