minidump/minidump_string_writer_test.cc - Issue 1566713002: Use base/macros.h instead of base/basictypes.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_string_writer_test.cc

Issue 1566713002: Use base/macros.h instead of base/basictypes.h (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Windows #incldue → #include Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: minidump/minidump_string_writer_test.cc

diff --git a/minidump/minidump_string_writer_test.cc b/minidump/minidump_string_writer_test.cc

index aa8e48c6a3c77e3200713bc0be05f2da678c1ad7..099732134ae13aee46d1a8b3c917fc9cd69f7196 100644

--- a/minidump/minidump_string_writer_test.cc

+++ b/minidump/minidump_string_writer_test.cc

@@ -14,15 +14,11 @@

#include "minidump/minidump_string_writer.h"

-#include <windows.h>

-#include <dbghelp.h>

-#include <sys/types.h>

#include <string>

-#include "base/basictypes.h"

#include "base/compiler_specific.h"

#include "base/format_macros.h"

+#include "base/macros.h"

#include "base/strings/string16.h"

#include "base/strings/stringprintf.h"

#include "base/strings/utf_string_conversions.h"

« no previous file with comments | « minidump/minidump_string_writer.cc ('k') | minidump/minidump_system_info_writer.h » ('j') | no next file with comments »