minidump/minidump_misc_info_writer_test.cc - Issue 1566713002: Use base/macros.h instead of base/basictypes.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_misc_info_writer_test.cc

Issue 1566713002: Use base/macros.h instead of base/basictypes.h (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Windows #incldue → #include Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: minidump/minidump_misc_info_writer_test.cc

diff --git a/minidump/minidump_misc_info_writer_test.cc b/minidump/minidump_misc_info_writer_test.cc

index de8cde3bfb23b1c944a1562a22c783fff1fd12e3..2b5dbe448acf9d301076c77622f28e243804d171 100644

--- a/minidump/minidump_misc_info_writer_test.cc

+++ b/minidump/minidump_misc_info_writer_test.cc

@@ -14,15 +14,13 @@

#include "minidump/minidump_misc_info_writer.h"

-#include <windows.h>

-#include <dbghelp.h>

#include <string.h>

#include <string>

#include <utility>

-#include "base/basictypes.h"

#include "base/compiler_specific.h"

+#include "base/macros.h"

#include "base/memory/scoped_ptr.h"

#include "base/strings/string16.h"

#include "base/strings/utf_string_conversions.h"