Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: util/win/command_line.cc

Issue 1566713002: Use base/macros.h instead of base/basictypes.h (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Windows #incldue → #include Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « util/win/capture_context_test.cc ('k') | util/win/command_line_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Crashpad Authors. All rights reserved. 1 // Copyright 2015 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "util/win/command_line.h" 15 #include "util/win/command_line.h"
16 16
17 #include <sys/types.h>
18
17 namespace crashpad { 19 namespace crashpad {
18 20
19 // Ref: 21 // Ref:
20 // http://blogs.msdn.com/b/twistylittlepassagesallalike/archive/2011/04/23/every one-quotes-arguments-the-wrong-way.aspx 22 // http://blogs.msdn.com/b/twistylittlepassagesallalike/archive/2011/04/23/every one-quotes-arguments-the-wrong-way.aspx
21 void AppendCommandLineArgument(const std::wstring& argument, 23 void AppendCommandLineArgument(const std::wstring& argument,
22 std::wstring* command_line) { 24 std::wstring* command_line) {
23 if (!command_line->empty()) { 25 if (!command_line->empty()) {
24 command_line->push_back(L' '); 26 command_line->push_back(L' ');
25 } 27 }
26 28
(...skipping 22 matching lines...) Expand all
49 // Backslashes aren’t special here. 51 // Backslashes aren’t special here.
50 command_line->append(backslash_count, L'\\'); 52 command_line->append(backslash_count, L'\\');
51 command_line->push_back(*i); 53 command_line->push_back(*i);
52 } 54 }
53 } 55 }
54 command_line->push_back(L'"'); 56 command_line->push_back(L'"');
55 } 57 }
56 } 58 }
57 59
58 } // namespace crashpad 60 } // namespace crashpad
OLDNEW
« no previous file with comments | « util/win/capture_context_test.cc ('k') | util/win/command_line_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698