Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Side by Side Diff: util/posix/close_stdio.cc

Issue 1566713002: Use base/macros.h instead of base/basictypes.h (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Windows #incldue → #include Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « util/numeric/int128_test.cc ('k') | util/posix/process_info.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "util/posix/close_stdio.h" 15 #include "util/posix/close_stdio.h"
16 16
17 #include <fcntl.h> 17 #include <fcntl.h>
18 #include <paths.h> 18 #include <paths.h>
19 #include <unistd.h> 19 #include <unistd.h>
20 20
21 #include "base/basictypes.h"
22 #include "base/files/scoped_file.h" 21 #include "base/files/scoped_file.h"
23 #include "base/logging.h" 22 #include "base/logging.h"
24 #include "base/posix/eintr_wrapper.h" 23 #include "base/posix/eintr_wrapper.h"
25 24
26 namespace crashpad { 25 namespace crashpad {
27 26
28 namespace { 27 namespace {
29 28
30 void CloseStdioStream(int desired_fd, int oflag) { 29 void CloseStdioStream(int desired_fd, int oflag) {
31 base::ScopedFD fd(HANDLE_EINTR(open(_PATH_DEVNULL, oflag))); 30 base::ScopedFD fd(HANDLE_EINTR(open(_PATH_DEVNULL, oflag)));
(...skipping 11 matching lines...) Expand all
43 42
44 void CloseStdinAndStdout() { 43 void CloseStdinAndStdout() {
45 // Open /dev/null for stdin and stdout separately, so that it can be opened 44 // Open /dev/null for stdin and stdout separately, so that it can be opened
46 // with the correct mode each time. This ensures that attempts to write to 45 // with the correct mode each time. This ensures that attempts to write to
47 // stdin or read from stdout fail with EBADF. 46 // stdin or read from stdout fail with EBADF.
48 CloseStdioStream(STDIN_FILENO, O_RDONLY); 47 CloseStdioStream(STDIN_FILENO, O_RDONLY);
49 CloseStdioStream(STDOUT_FILENO, O_WRONLY); 48 CloseStdioStream(STDOUT_FILENO, O_WRONLY);
50 } 49 }
51 50
52 } // namespace crashpad 51 } // namespace crashpad
OLDNEW
« no previous file with comments | « util/numeric/int128_test.cc ('k') | util/posix/process_info.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698