Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: util/misc/random_string_test.cc

Issue 1566713002: Use base/macros.h instead of base/basictypes.h (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Windows #incldue → #include Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « util/misc/pdb_structures.h ('k') | util/misc/scoped_forbid_return.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Crashpad Authors. All rights reserved. 1 // Copyright 2015 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "util/misc/random_string.h" 15 #include "util/misc/random_string.h"
16 16
17 #include <sys/types.h>
18
17 #include <set> 19 #include <set>
18 20
19 #include "base/basictypes.h" 21 #include "base/macros.h"
20 #include "gtest/gtest.h" 22 #include "gtest/gtest.h"
21 23
22 namespace crashpad { 24 namespace crashpad {
23 namespace test { 25 namespace test {
24 namespace { 26 namespace {
25 27
26 TEST(RandomString, RandomString) { 28 TEST(RandomString, RandomString) {
27 // Explicitly list the allowed characters, rather than relying on a range. 29 // Explicitly list the allowed characters, rather than relying on a range.
28 // This prevents the test from having any dependency on the character set, so 30 // This prevents the test from having any dependency on the character set, so
29 // that the implementation is free to assume all uppercase letters are 31 // that the implementation is free to assume all uppercase letters are
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 character_index < arraysize(character_counts); 64 character_index < arraysize(character_counts);
63 ++character_index) { 65 ++character_index) {
64 EXPECT_GT(character_counts[character_index], 0u) 66 EXPECT_GT(character_counts[character_index], 0u)
65 << allowed_characters[character_index]; 67 << allowed_characters[character_index];
66 } 68 }
67 } 69 }
68 70
69 } // namespace 71 } // namespace
70 } // namespace test 72 } // namespace test
71 } // namespace crashpad 73 } // namespace crashpad
OLDNEW
« no previous file with comments | « util/misc/pdb_structures.h ('k') | util/misc/scoped_forbid_return.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698