Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: snapshot/minidump/minidump_string_reader.cc

Issue 1566713002: Use base/macros.h instead of base/basictypes.h (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Windows #incldue → #include Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Crashpad Authors. All rights reserved. 1 // Copyright 2015 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "snapshot/minidump/minidump_string_reader.h" 15 #include "snapshot/minidump/minidump_string_reader.h"
16 16
17 #include <stdint.h>
18
17 #include "base/logging.h" 19 #include "base/logging.h"
18 #include "minidump/minidump_extensions.h" 20 #include "minidump/minidump_extensions.h"
19 21
20 namespace crashpad { 22 namespace crashpad {
21 namespace internal { 23 namespace internal {
22 24
23 bool ReadMinidumpUTF8String(FileReaderInterface* file_reader, 25 bool ReadMinidumpUTF8String(FileReaderInterface* file_reader,
24 RVA rva, 26 RVA rva,
25 std::string* string) { 27 std::string* string) {
26 if (rva == 0) { 28 if (rva == 0) {
(...skipping 14 matching lines...) Expand all
41 if (!file_reader->ReadExactly(&local_string[0], string_size)) { 43 if (!file_reader->ReadExactly(&local_string[0], string_size)) {
42 return false; 44 return false;
43 } 45 }
44 46
45 string->swap(local_string); 47 string->swap(local_string);
46 return true; 48 return true;
47 } 49 }
48 50
49 } // namespace internal 51 } // namespace internal
50 } // namespace crashpad 52 } // namespace crashpad
OLDNEW
« no previous file with comments | « snapshot/minidump/minidump_string_list_reader.cc ('k') | snapshot/minidump/module_snapshot_minidump.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698