Moved parent_->SchedulePaint() to Views::SetFillsBoundsOpaquely() and Views::SchedulePaint().

Moved parent_->SchedulePaint() to Views::SetFillsBoundsOpaquely() and Views::SchedulePaint().

Reland of patchset #8 id:140001 of https://codereview.chromium.org/1461673002/

Original patchset was reverted here https://codereview.chromium.org/1560723002/
due to memory leaks in tests.

TBR=sadrul@chromium.org,jonross@chromium.org,sky@chromium.org
BUG=551492, 546683
Original issue's description:
> This CL fixes a more general issue in Views that had a quick fix
> that landed here: https://codereview.chromium.org/1460733002/
>
> The general problem is that the layer owned by a parent View can
> become dirty/stale when a child view is painting to it's own layer.
> This CL fixes the problem by scheduling paints on the parent view
> when it may be dirty.
>
> BUG=551492, 546683
> TEST=ViewLayerTest.NoCrashWhenParentlessViewSchedulesPaintOnParent
>      ViewLayerTest.ScheduledRectsInParentAfterSchedulingPaint
>      ViewLayerTest.ParentPaintWhenSwitchingPaintToLayerFromFalseToTrue
>      ViewLayerTest.NoParentPaintWhenSwitchingPaintToLayerFromTrueToTrue
>
> Committed: https://crrev.com/c8761106916aac604f30fb2223cdbfb2bd3ffda3
> Cr-Commit-Position: refs/heads/master@{#367536}

Committed: https://crrev.com/5f90e3971ee381e0208ab3cb5dc6e9916f173487
Cr-Commit-Position: refs/heads/master@{#367831}

[bruthig, 2016-01-06 15:10:47]

The CQ bit was checked by bruthig@chromium.org

[commit-bot: I haz the power, 2016-01-06 15:10:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1566693002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1566693002/1

[bruthig, 2016-01-06 15:11:33]

jonross@, sadrul@, sky@, this is a re-land of a previous issue and I've marked
you as TBR.  Review if you wish.

[commit-bot: I haz the power, 2016-01-06 16:03:57]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-06 16:05:57]

Description was changed from

==========
Moved parent_->SchedulePaint() to Views::SetFillsBoundsOpaquely() and
Views::SchedulePaint().

Reland of patchset #8 id:140001 of https://codereview.chromium.org/1461673002/

Original patchset was reverted here https://codereview.chromium.org/1560723002/
due to memory leaks in tests.

TBR=sadrul@chromium.org,jonross@chromium.org,sky@chromium.org
BUG=551492, 546683

Original issue's description:
> This CL fixes a more general issue in Views that had a quick fix
> that landed here: https://codereview.chromium.org/1460733002/
>
> The general problem is that the layer owned by a parent View can
> become dirty/stale when a child view is painting to it's own layer.
> This CL fixes the problem by scheduling paints on the parent view
> when it may be dirty.
>
> BUG=551492, 546683
> TEST=ViewLayerTest.NoCrashWhenParentlessViewSchedulesPaintOnParent
>      ViewLayerTest.ScheduledRectsInParentAfterSchedulingPaint
>      ViewLayerTest.ParentPaintWhenSwitchingPaintToLayerFromFalseToTrue
>      ViewLayerTest.NoParentPaintWhenSwitchingPaintToLayerFromTrueToTrue
>
> Committed: https://crrev.com/c8761106916aac604f30fb2223cdbfb2bd3ffda3
> Cr-Commit-Position: refs/heads/master@{#367536}
==========

to

==========
Moved parent_->SchedulePaint() to Views::SetFillsBoundsOpaquely() and
Views::SchedulePaint().

Reland of patchset #8 id:140001 of https://codereview.chromium.org/1461673002/

Original patchset was reverted here https://codereview.chromium.org/1560723002/
due to memory leaks in tests.

TBR=sadrul@chromium.org,jonross@chromium.org,sky@chromium.org
BUG=551492, 546683

Original issue's description:
> This CL fixes a more general issue in Views that had a quick fix
> that landed here: https://codereview.chromium.org/1460733002/
>
> The general problem is that the layer owned by a parent View can
> become dirty/stale when a child view is painting to it's own layer.
> This CL fixes the problem by scheduling paints on the parent view
> when it may be dirty.
>
> BUG=551492, 546683
> TEST=ViewLayerTest.NoCrashWhenParentlessViewSchedulesPaintOnParent
>      ViewLayerTest.ScheduledRectsInParentAfterSchedulingPaint
>      ViewLayerTest.ParentPaintWhenSwitchingPaintToLayerFromFalseToTrue
>      ViewLayerTest.NoParentPaintWhenSwitchingPaintToLayerFromTrueToTrue
>
> Committed: https://crrev.com/c8761106916aac604f30fb2223cdbfb2bd3ffda3
> Cr-Commit-Position: refs/heads/master@{#367536}

Committed: https://crrev.com/5f90e3971ee381e0208ab3cb5dc6e9916f173487
Cr-Commit-Position: refs/heads/master@{#367831}
==========

[commit-bot: I haz the power, 2016-01-06 16:05:58]

Patchset 1 (id:??) landed as
https://crrev.com/5f90e3971ee381e0208ab3cb5dc6e9916f173487
Cr-Commit-Position: refs/heads/master@{#367831}

[sadrul, 2016-01-06 16:39:21]

On 2016/01/06 15:11:33, bruthig wrote:
> jonross@, sadrul@, sky@, this is a re-land of a previous issue and I've marked
> you as TBR.  Review if you wish.

Did you need to update any code/tests to fix the leak?

[bruthig, 2016-01-06 16:42:17]

On 2016/01/06 16:39:21, sadrul wrote:
> On 2016/01/06 15:11:33, bruthig wrote:
> > jonross@, sadrul@, sky@, this is a re-land of a previous issue and I've
marked
> > you as TBR.  Review if you wish.
> 
> Did you need to update any code/tests to fix the leak?

I did, I guess I should have shown that delta between two patch sets in this
review.  Sorry.
Essentially I changed the parent_view to be allocated on the stack, as opposed
to the heap.