Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1566653004: Use propagated type of receiver to determine return type, not type-inference type. (Closed)

Created:
4 years, 11 months ago by sra1
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use propagated type of receiver to determine return type, not type-inference type. The type-inference result is missing for some calls and might be less precise since type propagation happens after some simplification. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/0ed95c7737dc63964700cb44db6ec9f73664b8a6

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -22 lines) Patch
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 6 chunks +19 lines, -22 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
Kevin Millikin (Google)
LGTM. https://codereview.chromium.org/1566653004/diff/1/pkg/compiler/lib/src/cps_ir/type_propagation.dart File pkg/compiler/lib/src/cps_ir/type_propagation.dart (right): https://codereview.chromium.org/1566653004/diff/1/pkg/compiler/lib/src/cps_ir/type_propagation.dart#newcode2740 pkg/compiler/lib/src/cps_ir/type_propagation.dart:2740: AbstractConstantValue left = receiver; I think it's OK ...
4 years, 11 months ago (2016-01-07 18:17:03 UTC) #3
sra1
4 years, 11 months ago (2016-01-07 18:59:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0ed95c7737dc63964700cb44db6ec9f73664b8a6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698