Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 1566653002: Revert of Fix null dereference on MemoryCache. (Closed)

Created:
4 years, 11 months ago by yhirano
Modified:
4 years, 11 months ago
Reviewers:
sof, Nate Chapin
CC:
oilpan-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix null dereference on MemoryCache. (patchset #4 id:280001 of https://codereview.chromium.org/1537343002/ ) Reason for revert: The change breaks the oilpan build. Original issue's description: > Fix null dereference on MemoryCache. > > Usually a valid MemoryCacheEntry holds a non-null Resource as |m_resource|. But > when we hold a valid MemoryCacheEntry beyond destructive statements, it may be > evicted from the cache and get stale. That means |m_resource| can be null in > such cases. This CL checks it in order to avoid null dereference. > > BUG=488373 > > Committed: https://crrev.com/5de01d904d77ba5e5beaf4776e45e6eecd47a87b > Cr-Commit-Position: refs/heads/master@{#367779} TBR=japhet@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=488373 Committed: https://crrev.com/58c142c6eccd0287edcf0194391f785e45a8de92 Cr-Commit-Position: refs/heads/master@{#367788}

Patch Set 1 #

Messages

Total messages: 11 (4 generated)
yhirano
Created Revert of Fix null dereference on MemoryCache.
4 years, 11 months ago (2016-01-06 06:51:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1566653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1566653002/1
4 years, 11 months ago (2016-01-06 06:51:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-06 06:52:26 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/58c142c6eccd0287edcf0194391f785e45a8de92 Cr-Commit-Position: refs/heads/master@{#367788}
4 years, 11 months ago (2016-01-06 06:53:24 UTC) #6
sof
'twas fixed by https://crrev.com/367787
4 years, 11 months ago (2016-01-06 07:07:27 UTC) #8
yhirano
On 2016/01/06 07:07:27, sof wrote: > 'twas fixed by https://crrev.com/367787 I'm sorry for the mess.
4 years, 11 months ago (2016-01-06 07:11:14 UTC) #9
sof
4 years, 11 months ago (2016-01-06 07:17:58 UTC) #11
Message was sent while issue was closed.
On 2016/01/06 07:11:14, yhirano wrote:
> On 2016/01/06 07:07:27, sof wrote:
> > 'twas fixed by https://crrev.com/367787
> 
> I'm sorry for the mess.

no worries here; an easy issue to overlook & the CQ isn't of much help.

Powered by Google App Engine
This is Rietveld 408576698