Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Side by Side Diff: net/quic/quic_sent_packet_manager.h

Issue 1566633002: relnote: A small refactoring to make RecordSpuriousRetransmission() of QuicSentPacketManager simpl… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/quic/quic_sent_packet_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_QUIC_QUIC_SENT_PACKET_MANAGER_H_ 5 #ifndef NET_QUIC_QUIC_SENT_PACKET_MANAGER_H_
6 #define NET_QUIC_QUIC_SENT_PACKET_MANAGER_H_ 6 #define NET_QUIC_QUIC_SENT_PACKET_MANAGER_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <map> 10 #include <map>
(...skipping 322 matching lines...) Expand 10 before | Expand all | Expand 10 after
333 void MarkPacketHandled(QuicPacketNumber packet_number, 333 void MarkPacketHandled(QuicPacketNumber packet_number,
334 TransmissionInfo* info, 334 TransmissionInfo* info,
335 QuicTime::Delta delta_largest_observed); 335 QuicTime::Delta delta_largest_observed);
336 336
337 // Request that |packet_number| be retransmitted after the other pending 337 // Request that |packet_number| be retransmitted after the other pending
338 // retransmissions. Does not add it to the retransmissions if it's already 338 // retransmissions. Does not add it to the retransmissions if it's already
339 // a pending retransmission. 339 // a pending retransmission.
340 void MarkForRetransmission(QuicPacketNumber packet_number, 340 void MarkForRetransmission(QuicPacketNumber packet_number,
341 TransmissionType transmission_type); 341 TransmissionType transmission_type);
342 342
343 // Notify observers about spurious retransmits. 343 // Notify observers that packet with TransmissionInfo |info| is a spurious
344 // retransmission. It is caller's responsibility to guarantee the packet with
345 // TransmissionInfo |info| is a spurious retransmission before calling this
346 // function.
347 void RecordOneSpuriousRetransmission(const TransmissionInfo& info);
348
349 // Notify observers about spurious retransmits of packet with TransmissionInfo
350 // |info|.
344 void RecordSpuriousRetransmissions(const TransmissionInfo& info, 351 void RecordSpuriousRetransmissions(const TransmissionInfo& info,
345 QuicPacketNumber acked_packet_number); 352 QuicPacketNumber acked_packet_number);
346 353
347 // Newly serialized retransmittable and fec packets are added to this map, 354 // Newly serialized retransmittable and fec packets are added to this map,
348 // which contains owning pointers to any contained frames. If a packet is 355 // which contains owning pointers to any contained frames. If a packet is
349 // retransmitted, this map will contain entries for both the old and the new 356 // retransmitted, this map will contain entries for both the old and the new
350 // packet. The old packet's retransmittable frames entry will be nullptr, 357 // packet. The old packet's retransmittable frames entry will be nullptr,
351 // while the new packet's entry will contain the frames to retransmit. 358 // while the new packet's entry will contain the frames to retransmit.
352 // If the old packet is acked before the new packet, then the old entry will 359 // If the old packet is acked before the new packet, then the old entry will
353 // be removed from the map and the new entry's retransmittable frames will be 360 // be removed from the map and the new entry's retransmittable frames will be
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
414 // Records bandwidth from server to client in normal operation, over periods 421 // Records bandwidth from server to client in normal operation, over periods
415 // of time with no loss events. 422 // of time with no loss events.
416 QuicSustainedBandwidthRecorder sustained_bandwidth_recorder_; 423 QuicSustainedBandwidthRecorder sustained_bandwidth_recorder_;
417 424
418 DISALLOW_COPY_AND_ASSIGN(QuicSentPacketManager); 425 DISALLOW_COPY_AND_ASSIGN(QuicSentPacketManager);
419 }; 426 };
420 427
421 } // namespace net 428 } // namespace net
422 429
423 #endif // NET_QUIC_QUIC_SENT_PACKET_MANAGER_H_ 430 #endif // NET_QUIC_QUIC_SENT_PACKET_MANAGER_H_
OLDNEW
« no previous file with comments | « no previous file | net/quic/quic_sent_packet_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698